Recommend
2 
 Thumb up
 Hide
19 Posts

BoardGameGeek» Forums » BoardGameGeek Related » BGG Bugs

Subject: URL links + auto URLs broken for some links rss

Your Tags: Add tags
Popular Tags: bgg_bug_url [+] [View All]
Bruce Murphy
Australia
Pyrmont
NSW
flag msg tools
badge
Avatar
mbmbmbmbmb
For example, there appears to be no way to embed a clean link to this url

http://web.archive.org/web/20080128095137/http://www.cs.unimaas.nl/maarten.schadd/Fanorona/

eg.

www.cs.unimaas.nl/maarten.schadd/Fanorona/" target="_blank" class="postlink" rel="nofollow">here

in a forum post. I've even tried replacing the : and // with the relevant % escaped sequences but no luck. Several other more complex URLs seem to have similar problems.

B>
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Samuel Sol
Brazil
São Paulo
SP
flag msg tools
All engines full to awesome land!
badge
*tap* *tap* Is this thing on?
Avatar
mbmbmbmbmb
Hmm. I think I know what the problem might be. Checking it.
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Bruce Murphy
Australia
Pyrmont
NSW
flag msg tools
badge
Avatar
mbmbmbmbmb
Cheers.

B>
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
col_w
United Kingdom
Poole
Dorset
flag msg tools
badge
Avatar
mb
You could always tinyurl it.
1 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Steve Duff
Canada
Ottawa
Ontario
flag msg tools
badge
Avatar
mbmbmbmbmb
URL parsing is a bitch. Always some bloody thing that breaks your code.

The tinyurl.com suggestion is a good workaround.
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Bruce Murphy
Australia
Pyrmont
NSW
flag msg tools
badge
Avatar
mbmbmbmbmb
This is why reinventing the wheel, badly, is a problem.

B>
1 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Josh "Der Spieler" Spillers
United States
Texas
flag msg tools
badge
Avatar
mbmbmbmbmb
Here's another example in this thread:
http://www.boardgamegeek.com/article/5673544
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Russ Williams
Poland
Wrocław
Dolny Śląsk
flag msg tools
designer
badge
Avatar
mbmbmb
yohanleafheart wrote:
Hmm. I think I know what the problem might be. Checking it.

And... any progress? These broken URLs are a pretty frequent inconvenience in forum posts.

Also see http://www.boardgamegeek.com/thread/632834/malformed-urls-in... for more examples.
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
George
United States
Pennsylvania
flag msg tools
badge
You can take my game… when you pry my cold, dead fingers off the board!
Avatar
I have run into this quite a few times myself.

Here's one I had trouble with today (I also tried converting with a percent or url encoder with no success):
http://dictionary.reverso.net/french-english/définitivement

Also trying to paste in any sort of translate.google.com page will cause lots of trouble.
1 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Russ Williams
Poland
Wrocław
Dolny Śląsk
flag msg tools
designer
badge
Avatar
mbmbmb
This is pretty basic functionality that lots of people use (pasting URLs into forum posts - and then many users click the URLs), and it's not that hard to handle URLs compared to a lot of the code overhauls that go on here...

It seems like it ought to be an obvious low hanging fruit bug - a quick fix that benefits many users.
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Virre Linwendil Annergård
Sweden
Stockholm
flag msg tools
Forza Bajen!
badge
... and still sober
Avatar
mbmbmbmbmb
I don't think it is that easy to solve. The issue here seems to be one of database security, little bobby tables and all that.

Of course it might just be that a regexp do see where a url breaks says scan until not A-Z/0-9 acctualy some random urls would see if this is true

[url]http://www.åäö.se[/url]

[url]http://www.nottrue.net/åäö[/url]

[url]http://www.false.net/ü[/url]
-

Ah yes thats it

(Anything to not needing todo real workat work right)
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Russ Williams
Poland
Wrocław
Dolny Śląsk
flag msg tools
designer
badge
Avatar
mbmbmb
Right, I don't mean it's trivial, but it's not rocket science. E.g. it's obviously erroneously assuming ASCII and halting the link at any non-ASCII character, so any foreign text breaks unnecessarily. I don't think that has anything to do with paranoia about database security and executable URLs.

Or why does it allow ( but forbid ) in a link?

http://en.wikipedia.org/wiki/Go_(game)
so you need to use %29:
http://en.wikipedia.org/wiki/Go_%28game%29

And it's the sort of thing that can be incrementally improved - even if it quits barfing on some types of URLs, that would make users' lives easier.
1 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Virre Linwendil Annergård
Sweden
Stockholm
flag msg tools
Forza Bajen!
badge
... and still sober
Avatar
mbmbmbmbmb
acctualy I should have changed my answer, it is easier.

(Personaly I am mostly fascinated how & in urls are so darn problematic, well it is in xhtml as it is not valid. That took a while to get at work and even longer to fix (It is not my fault, I didn't build the system))
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Scott Alden
United States
Dallas
Texas
flag msg tools
admin
badge
Aldie's Full of Love!
Avatar
mb
Yeah - it's a bit frustrating. We've hacked on this thing for years and it still has problems.

If anyone has a regular expression that works for every case feel free to share.
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Virre Linwendil Annergård
Sweden
Stockholm
flag msg tools
Forza Bajen!
badge
... and still sober
Avatar
mbmbmbmbmb
Aldie wrote:
Yeah - it's a bit frustrating. We've hacked on this thing for years and it still has problems.

If anyone has a regular expression that works for every case feel free to share.


I assume you do not just one that validate according to the RFC though, for that apprently this is the place to look
http://stackoverflow.com/questions/827557/how-do-you-validat...

(I have however not read it trough it might be old and buggy anyway)
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Russ Williams
Poland
Wrocław
Dolny Śląsk
flag msg tools
designer
badge
Avatar
mbmbmb
It's certainly not my area of expertise, but here are some possibly useful links, for what they're worth.

http://www.blooberry.com/indexdot/html/topics/urlencoding.ht...
This has some javascript to process URLs. According to this page, ) should be safe to pass through.
Since you already permit ( I suppose you could easily modify the existing BGG code to also allow ) and that would solve a lot of annoying real-life cases (e.g. links to many wikipedia pages like "Go (game)") right there.


http://stackoverflow.com/questions/120951/how-can-i-normaliz...

 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
George
United States
Pennsylvania
flag msg tools
badge
You can take my game… when you pry my cold, dead fingers off the board!
Avatar
Everytime this happens I always try to put the link in quotes... even though it never helps, lol...
[url="xxxxx"]link text[/url]

I guess I always think if the auto-url doesn't work then if I simply tell it what the url is it'll do it. I guess it's not that simple though, eh?
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Bruce Murphy
Australia
Pyrmont
NSW
flag msg tools
badge
Avatar
mbmbmbmbmb
Aldie wrote:
Yeah - it's a bit frustrating. We've hacked on this thing for years and it still has problems.

If anyone has a regular expression that works for every case feel free to share.


If you're going to be stuffing it inside a href="", you can be pretty sanguine about what people include, simply letting them put anything they want that isn't a double quote and isn't a [/url] tag. If it's a broken URL, tough luck for them. To be honest, the auto-URL stuff is less critical than making specifically tagged URLs work properly.

B>
1 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
David Gregg
United States
Franklinville
NC
flag msg tools
designer
NightfallGame.com/FAQ
badge
boardgamegeek.com/thread/1234645
Avatar
mbmbmbmbmb
Came here to mention that the permalinks generated by a user's collection are themselves not working due to the URL issues. Example:

http://boardgamegeek.com/collection/user/s3rvant?rankobjectt...|thumbnail|status|rating|bggrating|comment&geekranks=Board+Game+Rank&own=1&ff=1&subtype=boardgame
 
 Thumb up
 tip
 Hide
  • [+] Dice rolls
Front Page | Welcome | Contact | Privacy Policy | Terms of Service | Advertise | Support BGG | Feeds RSS
Geekdo, BoardGameGeek, the Geekdo logo, and the BoardGameGeek logo are trademarks of BoardGameGeek, LLC.